New terminal #1297
Draft
New terminal #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
reviewed
Jun 11, 2024
|
We should keep an eye on https://github.com/patternfly/react-console which might have the UI pieces we will need. See https://github.com/patternfly/react-console/blob/main/packages/module/src/components/SerialConsole/SerialConsole.tsx and https://github.com/patternfly/react-console/blob/main/packages/module/src/components/SerialConsole/XTerm.tsx Check https://www.patternfly.org/extensions/react-console too |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 4a56e6d.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From cockpit times we still miss terminal in web UI.
Solution
Try to add it back.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.